search

mailgun / kafka-pixy

gRPC/REST proxy for Kafka
Apache License 2.0
768 stars 119 forks source link

Log rejected produce requests #149

Closed solsson closed 6 years ago

solsson commented 6 years ago

We use Pixy as webhook target for 3rd party services like Docker Registry. Some senders don't print error responses. In the case of Docker Registry we see "400 Bad Request unaccepted".

mailgun-ci commented 6 years ago

Can one of the admins verify this patch?

horkhe commented 6 years ago

Honestly, I am reluctant to accept this patch for two reasons:

  1. You debug issues with one application by adding logging in another. The response returned by Kafka-Pixy already contains that information;
  2. Even if I agreed to add logging, then the solution would need to be thorough - logging would need to be added to places where an error is returned and not just one particular case;