search

mailgun / kafka-pixy

gRPC/REST proxy for Kafka
Apache License 2.0
773 stars 118 forks source link

add configuration support for gRPC TLS #167

Closed maxthomas closed 5 years ago

maxthomas commented 5 years ago

this adds support for gRPC TLS in the configuration and in the application.

i think there's an issue in the current FromYAML method in that it doesn't actually read the grpc_address field, it just uses the one from defaultApp. so i'm not sure if that's worth fixing alongside this.

anyway, let me know if you have any feedback, i'd also be happy to add HTTPS security if you'd like to see that before merging.

mailgun-ci commented 5 years ago

Can one of the admins verify this patch?

horkhe commented 5 years ago

@thrawn01 do you have anything to add? The code of FromYAML looks weird because my original logic only loaded the Proxies part correctly, and the rest was set to default. #168 was created to track a fix for that.

horkhe commented 5 years ago

One more thing, if you could update the README and CHANGELOG files with information about support for TLS that would be great.

maxthomas commented 5 years ago

wasn't sure if it was an implemented or fixed, so put implemented and also tagged issue. let me know what you think