search

mailgun / kafka-pixy

gRPC/REST proxy for Kafka
Apache License 2.0
773 stars 118 forks source link

fix issue with configured listen grpc tcp addresses #169

Closed maxthomas closed 5 years ago

maxthomas commented 5 years ago

previous addresses were not being respected if configured.

this includes a failing test and a fix.

mailgun-ci commented 5 years ago

Can one of the admins verify this patch?

maxthomas commented 5 years ago

i'm not sure what's up with the CI - seems weird that it passed on 2/3 - is there a way to re-run it? also, the logs are too big to see where it failed.

horkhe commented 5 years ago

There is also UnixAddr parameter that should be fixed along with TCPAddr and GRPCAddr.

maxthomas commented 5 years ago

if you don't mind i'll wait to get the other MR merged in, then put this on top to avoid any conflicts

maxthomas commented 5 years ago

rebased off HEAD and reworked parsing to be a bit more logical, also added Unix/gRPC to test case. let me know what you think!

maxthomas commented 5 years ago

thank you! closing the relevant issue..