move to go mod - Githubissues

mailgun / kafka-pixy

gRPC/REST proxy for Kafka

Apache License 2.0

768 stars 119 forks source link

move to go mod #171

Closed maxthomas closed 5 years ago

maxthomas commented 5 years ago

hey @horkhe , would you and your team have any interest in moving the project to go mod? it'd make the project depend upon golang 1.11 or so, but that seems to be the case already in the CI file. let me know what you think!

horkhe commented 5 years ago

After they pulled a fast one on us with golang/dep I was hesitant to switch to go mod at early stage. But now it seems it is here to stay. I think the time has come to start using it.

maxthomas commented 5 years ago

sounds good. would you like the dependencies to still be vendored as well?

horkhe commented 5 years ago

Our internal Jenkins job expects them to be vendored, so let's keep them for now.

horkhe commented 5 years ago

Implemented in #174