search

mailgun / kafka-pixy

gRPC/REST proxy for Kafka
Apache License 2.0
773 stars 118 forks source link

fix issue w/client ID validation + set ID for producer connection #74

Closed rcoder closed 8 years ago

rcoder commented 8 years ago

Sarama validates the ClientID config flag with a regexp that disallows the : characters included in the timestamp format used in kafka-pixy. This change converts those to periods, and as a bonus squelches a warning generated by the producer client logic caused by a lack of a unique, non-null ClientID value there.

horkhe commented 8 years ago

@rcoder Thank you for your interest and contribution. As long as you at it, could you please also swap time and pid components in the client id. I wanted to do that myself to make the output of /topic/<name>/consumers API method look a little bit better.

mailgun-ci commented 8 years ago

Can one of the admins verify this patch?

horkhe commented 8 years ago

@mailgun-ci ok to test

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.07%) to 72.996% when pulling f7afff112d26b43dfb0d0143c11dfc43ed54d2f4 on rcoder:master into c6f602cdb33757537bb7f6beffb39026399a76dc on mailgun:master.

horkhe commented 8 years ago

Thank's a lot! Bugs, feature requests, and pull requests are always welcome.