mailgun / mailgun-js-boland

A simple Node.js helper module for Mailgun API.
http://bojand.github.io/mailgun-js
MIT License
894 stars 122 forks source link

mailgun-js beaks got #265

Open zdila opened 4 years ago

zdila commented 4 years ago

Just adding require('mailgun-js'); makes got failing.

const got = require('got');

require('mailgun-js');

got.get(`https://www.google.com/`).then(
  (res) => {
    console.log('DONE', res.headers);
  },
  (err) => {
    console.error('ERROR', err);
  },
);

Requirements:

"dependencies": {
    "got": "^11.3.0",
    "mailgun-js": "^0.22.0"
  }
tobyhinloopen commented 4 years ago

Same or similar error:

https://github.com/tobyhinloopen/openid-client-mailgun-js

axmachina commented 3 years ago

I can confirm this with the issue i've been encountering with shopify-api-node

https://github.com/MONEI/Shopify-api-node/issues/446

Specifically, mailgun breaks https.request and causes it to drop path from requests ("GET /" vs "GET /some/path").

axmachina commented 3 years ago

0.11.3 https://github.com/mailgun/mailgun-js-boland/releases/tag/v0.11.3

appears to be the culprit

dkoleary88 commented 3 years ago

Has anyone found a fix or workaround for this issue?