mailgun / mailgun-ruby

Mailgun's Official Ruby Library
Apache License 2.0
468 stars 184 forks source link

Add missing accessors #274

Closed Linuus closed 1 year ago

Linuus commented 1 year ago

The latest version (1.2.7) of the gem is broken. This PR: https://github.com/mailgun/mailgun-ruby/pull/262 makes calls to Mailgun.api_host and Mailgun.proxy_url but the accessors were never added.

I can't find that there are any tests for this code, so I didn't add any in this PR either. I don't really understand how the tests are structured to be honest :) But, it's a pretty bad sign when bugs like this does not break the test suite and makes it out all the way in a new gem version.

Fixes: https://github.com/mailgun/mailgun-ruby/issues/273