search

mailgun / talon

Apache License 2.0
1.27k stars 285 forks source link

Python 3 compatibility up to 3.6.1 #141

Closed yfilali closed 7 years ago

yfilali commented 7 years ago

This is to resolve issue #42.

The notable parts to take a good look at is the return type where some of the functions are returning byte arrays but the tests were asserting against strings which failed.

Also, some of the functions took bytearrays only and are now taking strings as well.

mailgun-ci commented 7 years ago

Can one of the admins verify this patch?

ad-m commented 7 years ago

@mailgun-ci , do you can link the report, please?

yfilali commented 7 years ago

@ad-m improved it a bit since initial commit to handle permission errors when trying to write the python 3 converted classifier. It uses a temp file as a fallback now.

obukhov-sergey commented 7 years ago

@mailgun-ci test this please