search

mailgun / talon

Apache License 2.0
1.27k stars 285 forks source link

Increase flexibility of bruteforce signature extration #166

Open RonRademaker opened 6 years ago

RonRademaker commented 6 years ago

Allows overriding line length, max line length (useful if you expect disclaimers) and greetings (useful from a language perspective) when extracting signatures bruteforce

mailgun-ci commented 6 years ago

Can one of the admins verify this patch?

obukhov-sergey commented 6 years ago

@mailgun-ci test this please

RonRademaker commented 6 years ago

Thanks for the feedback, I processed it

obukhov-sergey commented 6 years ago

@mailgun-ci test this please

obukhov-sergey commented 6 years ago

@RonRademaker sorry for delay with the merge, can you plz add abc to setup.py to make tests pass?

RonRademaker commented 6 years ago

Any way I can locally run the tests to see if they pass before pushing changes?

obukhov-sergey commented 6 years ago

@mailgun-ci test this please

obukhov-sergey commented 6 years ago

@RonRademaker sure, just run nosetests from the repo folder, you might need to "pip install nose" and "pip install mock", they're also in test_require part of setup.py; we plan to migrate to travis ci as well, so that you don't have to run tests yourself locally.