search

mailgun / talon

Apache License 2.0
1.27k stars 285 forks source link

Fix splitter detection bug #178 #180

Closed raphael0202 closed 4 years ago

raphael0202 commented 5 years ago

See https://github.com/mailgun/talon/issues/178

mailgun-ci commented 5 years ago

Can one of the admins verify this patch?

obukhov-sergey commented 5 years ago

@mailgun-ci test this please

obukhov-sergey commented 5 years ago

Thx for the PR @raphael0202 can you plz fix the test:

...........................................................F.............................
======================================================================
FAIL: tests.text_quotations_test.test_preprocess
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/jenkins/shiningpanda/jobs/b20cb595/virtualenvs/d41d8cd9/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/var/lib/jenkins/workspace/lib-py-talon-pr/tests/text_quotations_test.py", line 693, in test_preprocess
    eq_(prepared_msg, quotations.preprocess(msg, '\n'))
AssertionError: 'Hello\nSee @@http://google.com\n@@ for more\ninformation\n On Nov 30, 2011, at 12:47 PM, Somebody <\n416ffd3258d4d2fa4c85cfa4c44e1721d66e3e8f4\n@example.com>wrote:\n\n> Hi' != u'Hello\nSee @@http://google.com\n@@ for more\ninformation On Nov 30, 2011, at 12:47 PM, Somebody <\n416ffd3258d4d2fa4c85cfa4c44e1721d66e3e8f4\n@example.com>wrote:\n\n> Hi'
raphael0202 commented 5 years ago

@obukhov-sergey I've sent a patch, the test should be fixed, even if I didn't manage to run the unit tests locally.

obukhov-sergey commented 5 years ago

@mailgun-ci test this please