search

mailgun / talon

Apache License 2.0
1.27k stars 285 forks source link

Split non-ML part into a new talon-core package #200

Open andersk opened 5 years ago

andersk commented 5 years ago

The nonstandard setup.py install --no-ml option didn’t work correctly with pip. We could move the ML dependencies into an extra, but that approach was previously rejected (#121): extras can’t be enabled by default, so it could have been disruptive to existing users. Instead, we split off a new talon-core package with no ML dependencies, and have talon re-export everything from it.

Fixes #130; fixes #131.

mailgun-ci commented 5 years ago

Can one of the admins verify this patch?

andrewelkins commented 4 years ago

This is fantastic. Using the fork, but LGTM.

benbrandt commented 4 years ago

Have this would be amazing. Any progress on merging this?

andersk commented 2 years ago

@horkhe Can you please comment on whether this approach is acceptable for upstream? Zulip has been stuck on our fork of Talon for six years due to this issue and we would very much like to unfork it.

If this is acceptable, I’m happy to respin this for the current version.