search

mailgun / talon

Apache License 2.0
1.27k stars 285 forks source link

Strip down Talon #97

Closed umairwaheed closed 8 years ago

umairwaheed commented 8 years ago

Allow Talon to be installed without ML.

mailgun-ci commented 8 years ago

Can one of the admins verify this patch?

umairwaheed commented 8 years ago

This is a work in progress at the moment.

umairwaheed commented 8 years ago

Ready for review. This PR also makes the non-ML part Python 3 compatible.

obukhov-sergey commented 8 years ago

@mailgun-ci test this please

obukhov-sergey commented 8 years ago

@umairwaheed thank you very much for the PR! Looks good to me except for the comments.

umairwaheed commented 8 years ago

@obukhov-sergey, no problem and thanks for looking into this. I have updated the PR according to the feedback. Please review.

obukhov-sergey commented 8 years ago

@mailgun-ci test this please

wasabigeek commented 8 years ago

@umairwaheed how do I use the no-ml option?

umairwaheed commented 8 years ago

@wasabigeek, you can do python setup.py install --no-ml.

wasabigeek commented 8 years ago

thanks @umairwaheed - it doesn't work with pip I suppose

umairwaheed commented 8 years ago

@wasabigeek, with pip you can do pip install talon --install-option="--no-ml". You should add --no-deps option to avoid installing requirements automatically.