search

mailgun / wordpress-plugin

Mailgun's Wordpress Plugin
GNU General Public License v2.0
48 stars 53 forks source link

Admin notice improvements. #174

Closed oleksandr-mykhailenko closed 8 months ago

oleksandr-mykhailenko commented 8 months ago

Small code cleanup

midweste commented 8 months ago

https://github.com/mailgun/wordpress-plugin/pull/174/files#diff-35327cdcf196c01a80be6f8a02b58f139b1e12c01bdad9aa86a4b1a3c63484f7R340

Missing check if session exists is causing warning

Warning: Undefined global variable $_SESSION in /app/web/wp-content/plugins/mailgun/includes/admin.php on line 340 Warning: Trying to access array offset on value of type null in /app/web/wp-content/plugins/mailgun/includes/admin.php on line 340

oleksandr-mykhailenko commented 8 months ago

https://github.com/mailgun/wordpress-plugin/pull/174/files#diff-35327cdcf196c01a80be6f8a02b58f139b1e12c01bdad9aa86a4b1a3c63484f7R340

Missing check if session exists is causing warning

Warning: Undefined global variable $_SESSION in /app/web/wp-content/plugins/mailgun/includes/admin.php on line 340 Warning: Trying to access array offset on value of type null in /app/web/wp-content/plugins/mailgun/includes/admin.php on line 340

Gotcha, thank you for that

midweste commented 8 months ago

https://github.com/mailgun/wordpress-plugin/pull/174/files#diff-35327cdcf196c01a80be6f8a02b58f139b1e12c01bdad9aa86a4b1a3c63484f7R340 Missing check if session exists is causing warning Warning: Undefined global variable $_SESSION in /app/web/wp-content/plugins/mailgun/includes/admin.php on line 340 Warning: Trying to access array offset on value of type null in /app/web/wp-content/plugins/mailgun/includes/admin.php on line 340

Gotcha, thank you for that

thank you! I'm sorry I don't have the time at the moment to put in a pull request.

midweste commented 7 months ago

Just got the most recent version, thank you so much for adding the check. Appreciate it!