search

mailgun / wordpress-plugin

Mailgun's Wordpress Plugin
GNU General Public License v2.0
48 stars 53 forks source link

Undefined variable: from_name on every email process #49

Closed abdusfauzi closed 7 years ago

abdusfauzi commented 7 years ago

Keep getting this error in my log. thing is, it never happen on my development server :( Both using WooCommerce. But the email reached Mailgun server.

2017/02/03 01:01:01 [error] 21551#21551: *13767 FastCGI sent in stderr: "PHP message: PHP Notice: Undefined variable: from_name in /app/plugins/mailgun/includes/wp-mail-api.php on line 206 PHP message: PHP Notice: Undefined variable: from_email in /app/plugins/mailgun/includes/wp-mail-api.php on line 207" while reading response header from upstream, client: x.x.x.x, server: thesbx.com, request: "GET /core/wp-admin/admin-ajax.php?action=mailgun-test&_wpnonce=0112a12f84 HTTP/1.1", upstream: "fastcgi://unix:/run/php/php7.0-fpm.sock:", host: "website.com", referrer: "https://website.com/core/wp-admin/options-general.php?page=mailgun"

pirogoeth commented 7 years ago

@abdusfauzi thanks for filing this as well! I've got a fix for it and I will push it / PR it soon. Any chance the server that was giving that error was running in strict mode?

abdusfauzi commented 7 years ago

@pirogoeth how do i check on that strict mode?

pirogoeth commented 7 years ago

@abdusfauzi It's an error_reporting thing - either in code, or in your php.ini. Check this Stack Overflow post.

abdusfauzi commented 7 years ago

@pirogoeth Currently, this is the setting in php.ini:

error_reporting = E_ALL & ~E_DEPRECATED & ~E_STRICT

pirogoeth commented 7 years ago

@abdusfauzi Sorry about the delay - that's odd, but I'll get it fixed with this release! Thank you for bringing this to my attention!

pirogoeth commented 7 years ago

Fixed in the 1.5.8.1 release :)