Closed latanasov closed 7 years ago
Hey! Amazing work!! It sounds really great!
I have some review:
MessageFormat
which contains:
MessageFormatStrategyInterface.php
(and remove the interface from MailjetTransport)MessagePayloadV3.php
(don't forget the uppercase at first caracter because it's a class name)MessagePayloadV31.php
Utils.php
in this folder or create a BaseMessagePayload.php
which implements MessageFormatStrategyInterface
and all MessagePayloadXXX will extends from BaseMessagePayload.In order to respect the SRP.
Hi @Nightbr , thank you for your suggestions- they are good and will be implemented :)
Really great implementation BTW, I really love the way it automatically format the payload for API V3 or V3.1 👍
I just made some code review (doc, ...) just few minor things to fix.
Add to that, I have created some test.json in the folder Tests/Resources
, I think we can retrieve them and put them into subfolder such as:
Tests\Resources\V3
: https://github.com/mailjet/MailjetSwiftMailer/tree/master/Tests/ResourcesTests\Resources\V31
: https://github.com/mailjet/MailjetSwiftMailer/tree/sendAPI3.1/Tests/ResourcesIt could be used for more unit tests.
@Nightbr your suggestions are very appreciated, already working on them :)
Added support for v3 and v3.1 send API + bug fixes.