mailjet / MailjetSwiftMailer

A SwiftMailer transport implementation for Mailjet
MIT License
26 stars 24 forks source link

Support v3 and v3.1 #1

Closed latanasov closed 7 years ago

latanasov commented 7 years ago

Added support for v3 and v3.1 send API + bug fixes.

Nightbr commented 7 years ago

Hey! Amazing work!! It sounds really great!

I have some review:

In order to respect the SRP.

latanasov commented 7 years ago

Hi @Nightbr , thank you for your suggestions- they are good and will be implemented :)

Nightbr commented 7 years ago

Really great implementation BTW, I really love the way it automatically format the payload for API V3 or V3.1 👍

I just made some code review (doc, ...) just few minor things to fix.

Add to that, I have created some test.json in the folder Tests/Resources, I think we can retrieve them and put them into subfolder such as:

It could be used for more unit tests.

latanasov commented 7 years ago

@Nightbr your suggestions are very appreciated, already working on them :)

latanasov commented 7 years ago

@Nightbr one more time thanks for your recommendations, they have been implemented with the recent commit .