MailjetTransport.php optimation

mailjet / MailjetSwiftMailer

A SwiftMailer transport implementation for Mailjet

MIT License

26 stars 24 forks source link

Open kevinveenbirkenbach opened 6 years ago

kevinveenbirkenbach commented 6 years ago

There are the following issues in the file MailjetTransport.php:

PHPDocs are wrong:

some @parameters are not declared
some @throws are not declared
some @returns contain not all possible return types
some @var use relative paths which can not be mapped by some IDE's e.g. (PHPStorm)

Logic:

Variables:

kevinveenbirkenbach commented 6 years ago

Please merge pull request #17 ;)

kevinveenbirkenbach commented 6 years ago

It would be really nice if I could get some kind of feedback ;)

Nightbr commented 6 years ago

ping @mailjet/dev-evangelist ?

kachar commented 6 years ago

Hey! I've added some ideas for improvement as we're on the optimisation topic. Please check the PR