search

mailjet / api-documentation

Mailjet API Guides
https://dev.mailjet.com/guides
22 stars 25 forks source link

[GO docs] Modified the "MailjetAttachment" to "Attachment" #4

Closed xescugc closed 6 years ago

xescugc commented 7 years ago

This part of the documentation is out of date compared to the actual lib. It refers to MailjetAttachment instead of Attachment which is the correct name of the struct :).

I've investigated a little and I've found the commit in which this change was made on the code of the lib.

https://github.com/mailjet/mailjet-apiv3-go/commit/0a22affb8bf4cb236011fe7ad005806a8310ad3f#diff-14a751520174bf37c6d5f007451ef211L77

https://github.com/mailjet/mailjet-apiv3-go/commit/0a22affb8bf4cb236011fe7ad005806a8310ad3f#diff-14a751520174bf37c6d5f007451ef211L99

BTW, work perfectly ;)

Zhivko-Mailjet commented 7 years ago

@XescuGC Thank you for spotting the discrepancy and for the commit! We will adjust the documentation accordingly!

adamyanliev commented 6 years ago

fixed a while ago, closing the PR. thanks