search

mailjet / mailjet-apiv3-nodejs

[API v3] Official Mailjet API v3 NodeJS wrapper
https://dev.mailjet.com
MIT License
235 stars 69 forks source link

Use http for API requesting #202

Closed dobobaie closed 2 years ago

dobobaie commented 2 years ago

Recently I got a SSL error during integration tests because node-mailjet request by default on secure connection aka HTTPS secure option with true as default value, should be use to define a secure connection or not

scroll17 commented 2 years ago

Hey @dobobaie

At the moment I'm running the integration tests on my computer and I don't receive anyone errors. \ I think that an error with SSL occurred because that was a problem may be with your host or maybe with the SSL certificate on the Mailjet server-side.

Library already had this feature but it was removed in this PR - use only https and I think that using the HTTPS instead of HTTP it's a good tone because you need always send your api key and api secret for receiving access to all Mailjet features and without HTTPS you will always send your secret data without secure that will give access for third-party people and services that is very bad.

scroll17 commented 2 years ago

This issue will be closed