search

mailman-elixir / mailman

Mailman provides a clean way of defining mailers in your Elixir applications
https://github.com/mailman-elixir/mailman
Other
203 stars 73 forks source link

TestingAdapter `deliver` function doesn't return the same type as ExternalSmtpAdapter #48

Open martinos opened 8 years ago

martinos commented 8 years ago

The TestingAdapter.deliver function returns a Task, however the ExternalSmtpAdapter.deliver returns a tuple: {:ok, message}.

I think that both function should return the same type, it would make tests behave more like production code.

IamfromSpace commented 8 years ago

+1 for this. Will be pointing to your branch until the PR goes through.

hamann commented 8 years ago

@kamilc Is there a reason to have different results? Writing code with tests and matching against result isn't possible because of this

zberkom commented 8 years ago

👍 Experiencing the same issue here. Both adapters should return a Task.