search

mailman-elixir / mailman

Mailman provides a clean way of defining mailers in your Elixir applications
https://github.com/mailman-elixir/mailman
Other
203 stars 73 forks source link

Removed compiletime deprecations #63

Closed leaexplores closed 7 years ago

leaexplores commented 7 years ago

Hi,

I have a go at removing a few deprecations that were present in the build with latest elixir version.

The following changes were done :

Most of these deprecations are present when using

Erlang/OTP 19 [erts-8.2] [source] [64-bit] [smp:4:4] [async-threads:10] [hipe] [kernel-poll:false] [dtrace]

Elixir 1.3.4

Here is the errors that were outputted during compilation :

warning: variable "get_mix_config" does not exist and is being expanded to "get_mix_config()", please use parentheses to remove the ambiguity or change the variable name
  lib/mailman/context.ex:9

warning: variable "mix_test_config" does not exist and is being expanded to "mix_test_config()", please use parentheses to remove the ambiguity or change the variable name
  lib/mailman/context.ex:30

warning: variable "pure_from" is unused
  lib/mailman/external_smtp_adapter.ex:31

warning: variable "mime_types" does not exist and is being expanded to "mime_types()", please use parentheses to remove the ambiguity or change the variable name
  lib/mailman/attachment.ex:717

warning: variable "uri" is unused
  lib/mailman/attachment.ex:688

warning: variable "deliveries" does not exist and is being expanded to "deliveries()", please use parentheses to remove the ambiguity or change the variable name
  lib/mailman/test_server.ex:18

warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to remove the ambiguity or change the variable name
  lib/mailman/test_server.ex:36

warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to remove the ambiguity or change the variable name
  lib/mailman/test_server.ex:41

warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to remove the ambiguity or change the variable name
  lib/mailman/test_server.ex:46

warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to remove the ambiguity or change the variable name
  lib/mailman/test_server.ex:72

Thanks for looking into it !

kamilc commented 7 years ago

Thanks and sorry for such a late merge!