Add credo for static code analysis

mailman-elixir / mailman

Mailman provides a clean way of defining mailers in your Elixir applications

https://github.com/mailman-elixir/mailman

Other

203 stars 73 forks source link

Add credo for static code analysis #77

Closed arunvelsriram closed 6 years ago

arunvelsriram commented 6 years ago

As per #75 I have added credo package and a basic credo configuration for static code analysis.

Currently, credo is reporting around 500 issues:

With this as starting point, we can start working towards fixing the issues reported by credo.

And for the consistency issues issues we might have to decide on the code format we are going to use throughout the project.

skosch commented 6 years ago

Sorry I totally missed this! I'll have to figure out how to turn on email notifications for this project :)

Thank you for this, it's a good first step, and should be a risk-free merge. You're more than welcome to embark on a code-clean-up journey if you'd like to volunteer your time for it – personally I like the recommendations in most of the popular Elixir style guides, but I'm not dogmatic about it. Thanks again!

arunvelsriram commented 6 years ago

No worries.

Okay. I will try to do some exploration on the recommendations from other Elixir projects and send PRs whenever possible.