fixing some more log rotation warnings

mailserver2 / mailserver

Simple and full-featured mail server using Docker

https://store.docker.com/community/images/mailserver2/mailserver

MIT License

144 stars 30 forks source link

fixing some more log rotation warnings #26

Closed AndrewSav closed 4 years ago

AndrewSav commented 4 years ago

Description

Fixes https://github.com/mailserver2/mailserver/issues/24

Type of change

[X] Bug fix (non-breaking change which fixes an issue)

Status

[X] In development

Todo List

[X] Implementation
[X] Testing

How has this been tested ?

docker-compose up -d --force-recreate with the new image; docker exec -it mailserver bash, inside the container run /usr/sbin/logrotate -f /etc/logrotate.conf, confirm that there was no warnings.

An image is published in andrewsav/mailserver:logrotate-1 with this change. @pollux will run it for awhile and will report their findings. Until then the PR will remain open.

SaraSmiseth commented 4 years ago

LGTM

AndrewSav commented 4 years ago

@SaraSmiseth @sknight80 guys I'm not sure what to do with this one. @pollux who requested it does not have time to test it: I wanted someone to run it for a few weeks and report back.

Since this is not happening, what do I do? Just close it off? Or, since the risk is not great, merge it anyway?

pollux commented 4 years ago

Sorry, i was and i am busy these days. But i changed to @AndrewSav image now and will report back to you.

pollux commented 4 years ago

I got no log rotation error mail so far. So this looks real promising. I will keep using the modified image for some additional weeks and get back to you if there is any error or i think we're fine.

pollux commented 4 years ago

No error until now. I guess we can merge this PR and release a new patch-version.

AndrewSav commented 4 years ago

@pollux noted. Thank you for testing