search

mailserver2 / mailserver

Simple and full-featured mail server using Docker
https://store.docker.com/community/images/mailserver2/mailserver
MIT License
141 stars 30 forks source link

Remove travis badge from the repo frontpage readme #39

Closed AndrewSav closed 3 years ago

AndrewSav commented 3 years ago

Classification

Reproducibility

Description

No that we got rid of travis build I'd like to remove the badge from readme. But first I'd like to find out if we just remove it, or can we replace it on something github actions based?

@SaraSmiseth can you explain how the github actions that you set up work? Do we still have automated tests with actions? Can we use an actions badge. E,g, example workflow?

Also I would like to understand a bit more why are we having so many workflows (one per test stage), cannot we just run bare make and be done with it?

Steps to reproduce

Currently if you look at the front page of the repo, you will see that the build if failing.

Expected results

A badge that accurately describes the state of the build or no badge at all.

Actual results

Travis badge, although travis has been removed.

AndrewSav commented 3 years ago

Also it's been almost a year and a half since we forked. Maybe it's time to remove the hardware donation button? If not, we should clarify that this button leads to the original author and not to the current maintainers?

SaraSmiseth commented 3 years ago

@SaraSmiseth can you explain how the github actions that you set up work? Do we still have automated tests with actions? Can we use an actions badge. E,g, example workflow?

The actions I set up only run on pull requests into master. To have automatic builds for every push / merged pr in master we need to add this to the workflows.

on:
  push:
    branches: master

I'm not sure if we need that to show the correct status in the badge, but yes that link should work for the badge.

Also I would like to understand a bit more why are we having so many workflows (one per test stage), cannot we just run bare make and be done with it?

Yes we can change that and only use one workflow. With multiple workflows we can see the results of all test stages if some tests fail. With only one we can see the failing tests of the last stage that ran and not the following.

Also it's been almost a year and a half since we forked. Maybe it's time to remove the hardware donation button?

Yes we should remove it. I checked the link and I don't even see a bitcoin or other crypto address there.