mailvelope / keyserver

A simple OpenPGP public key server that validates email address ownership of uploaded keys.
https://keys.mailvelope.com
GNU Affero General Public License v3.0
414 stars 62 forks source link

Add dotenv dependency in order to allow config/default.js to read values #117

Closed nsauter closed 1 year ago

nsauter commented 3 years ago

config/default.js tries to read values from .env files but it's missing the dotenv npm package. This fix will add the dotenv package and needed config.

for example:

  mongo: {
    uri: process.env.MONGO_URI,
    user: process.env.MONGO_USER,
    pass: process.env.MONGO_PASS
  },
stradarius commented 3 years ago

Does it really make sense to support .env-files as it is possible the configure the settings in the config-files? Currently process.env.MONGO_URI returns the value of the environment variable MONGO_URI.

nsauter commented 3 years ago

Im not the owner of the project and i dont care if it makes sense to read values from .env. All i see is, that the project tries to read vaules from .env but the needed package and configuration is missing. Im just trying to fix that issue.

toberndo commented 1 year ago

Custom config files have now been removed and instead .env or environment variables should be used for configuration.