mailwatch / MailWatch

MailWatch for MailScanner is a web-based front-end to MailScanner
http://mailwatch.org/
GNU General Public License v2.0
117 stars 66 forks source link

enhancement for optionally hiding nonspams on quarantine display #1268

Closed dneuhaeuser closed 1 year ago

dneuhaeuser commented 1 year ago

enhance quarantine.php display to regard all HIDE_... configuration options like quarantine_report.inc.php does.

this is especially useful when you have Mailscanner configured like this: Non Spam Actions = store-nonspam ...

Then you can get only the relevant quarantine to display with mailwatch config: define('HIDE_UNKNOWN', true);

shawniverson commented 1 year ago

I don't think this is desired behavior for some folks (myself included). Although I don't want certain things in the quarantine report, I want to be able to see all mail in the UI. Perhaps need an option to toggle this functionality so that both behaviors can be achieved.

dneuhaeuser commented 1 year ago

So, you have HIDE_UNKNOWN = true but want to see the nonspam mails on the quarantine page?

My users actually found this very confusing. They only go to the quarantine page to release spam or bad mails and expect to see only the mails which where reported by quarantine_report there.

All mails are always visible in message listing and message operations, to inspect non-spams for example.

Where is the point to show non-spams in the quarantine?

shawniverson commented 1 year ago

I agree that may be desirable for users. I think there should be a setting that enables this desired behavior as an option so that those that don't want that behavior can disable it.

dneuhaeuser commented 1 year ago

I added a configuration parameter to enable or disable whether the hide filters are applied to the quarantine page.

endelwar commented 1 year ago

Thanks Dennis!