search

main-- / windows-gaming

This project makes it easy and straightforward to set up PCI/VGA passthrough on your system. - OR AT LEAST IT WOULD, IF IT WASNT DEAD
6 stars 1 forks source link

Switch to tokio-signal instead of using our homebrew signalfd handler. #129

Closed main-- closed 7 years ago

main-- commented 7 years ago

Needs testing.

oberien commented 7 years ago

I don't know which behaviour you are trying to achieve, but when I pressed Ctrl+C, thread 'main' panicked at 'Unexpected error: Connection reset by peer (os error 104)', src/driver/mod.rs:123 instantaneous without Windows properly shutting down.

If the intended behaviour is for Windows to first shutdown correctly, then I'd suggest to abort on the second interrupt / sigterm.

main-- commented 7 years ago

Thanks for testing.

As documented in #25, Ctrl+C issues a SIGINT to qemu directly as well. There are ways to work around that but that's orthogonal.