Closed oberien closed 7 years ago
If an entry / exit is done on a different control connection, x11-edge-grab crashes / is in an invalid state.
Don't allow this at all, it doesn't make sense. (I believe that's what the code already does?)
Currently while a TemporaryLightEntry is being performed, you can still echo
into ncat
to create a new connection and execute IoExit
or IoEntry
. Also while attached, you can still Alt+Ctrl+Ins to detach. Do you mean that I should disable all of the above as soon as a socket is connected which has executed a TemporaryLightEntry, or just disable Alt+Ctrl+Ins while in a temp entry?
Ah, that's what you mean. I thought you just meant a second (concurrent) temporary entry.
In that case, just do what makes sense. Prohibiting light IO entry during temporary makes sense (as you're already in there) but you might just as well argue that since you're only moving your mouse (temporary entry) the proper thing to do is "upgrade" from temporary to regular light entry.
As I said, I won't be a user of this feature and am thus not really qualified to comment on design details like this.
Fix #128
TODO:
register
errors in x11-edge-grab.IoState::TemporaryLightEntry
)Backlog: