search

main-- / windows-gaming

This project makes it easy and straightforward to set up PCI/VGA passthrough on your system. - OR AT LEAST IT WOULD, IF IT WASNT DEAD
6 stars 1 forks source link

Initial autoupdate implementation #153

Closed main-- closed 7 years ago

main-- commented 7 years ago

Needs more testing.

Fixes #126.

oberien commented 7 years ago

Is it possible to attach the cd drive dynamically with device_add only if the GA is outdated, and remove it again when the GA is updated? I think it feels weird to have the GA.iso attached at all times.

Otherwise lgtm

main-- commented 7 years ago

@oberien That's what I was planning to do initially. However, there's no straightforward way to tell if/when the device is going to be ready. Plus, implementing the required QMP commands is somewhat weird (see #131).

Permanently attaching the GA ISO is definitely not perfect but not that big of a deal either. It's there, whatever, just ignore it.

Hypervisors have traditionally addressed this by creating an optical drive at boot time and allowing you to insert/remove ISO images at runtime. This does not work here however as the corresponding qemu APIs are still unstable/experimental.

oberien commented 7 years ago

You should create a new issue then just to keep it in mind. (Also don't forget to update the reference in #131 ).

If it wasn't for "Needs more testing.", I'd approve this PR.