main-educational / brain_encoding_decoding

A jupyter book on brain decoding using functional magnetic resonance imaging
https://main-educational.github.io/brain_encoding_decoding/intro.html
MIT License
8 stars 10 forks source link

Issue on page /svm_decoding.html #37

Open Andjelaaaa opened 1 year ago

Andjelaaaa commented 1 year ago

Hi, at the last step where the accuracy is printed for the Fast Regularized Ensembles of models (frem) as follows: print('F1 scoreswith FREM') for category in categories: print(category, '\t\t {:.2f}'.format(np.mean(decoder.cv_scores_[category]))) Shouldn't it be averaged using frem scores instead of the ones from the decoder model? Hence, it would be: print('F1 scoreswith FREM') for category in categories: print(category, '\t\t {:.2f}'.format(np.mean(frem.cv_scores_[category])))

PeerHerholz commented 1 year ago

Hi @Andjelaaaa,

thank you very much for opening this issue and pointing this out.

I think you are correct. Just checking with @bthirion who prepared and presented this part: that's a typo, right?

Thx again.

Cheers, Peer

bthirion commented 1 year ago

You're absolutely right ! Sorry for the mistake

PeerHerholz commented 1 year ago

Thx for the reply @bthirion and no worries at all!

@Andjelaaaa would you be up for submitting a small PR to fix this? Otherwise, I can do it as well.