main-educational / brain_encoding_decoding

A jupyter book on brain decoding using functional magnetic resonance imaging
https://main-educational.github.io/brain_encoding_decoding/intro.html
MIT License
8 stars 11 forks source link

Issues with Flattening Before Global Mean Pooling and Missing Non-Linearities Before Linear Layers #39

Open gpefanis opened 1 month ago

gpefanis commented 1 month ago

Hi! I've been working with your GCN implementation and noticed a few issues that could affect the model's performance:

  1. Global Mean Pooling issue:
  1. Missing Non-Linearity Before Linear Layers:
x = self.fc1(x)
x = self.dropout(x)
x = self.fc2(x)
x = self.dropout(x)
x = self.fc3(x)

Suggested fix for FC layers
x = F.relu(self.fc1(x))
x = self.dropout(x)
x = F.relu(self.fc2(x))
x = self.dropout(x)
x = self.fc3(x)`

Would love to hear your thoughts and see if these can be addressed. Thanks for the great tutorial!

PeerHerholz commented 1 month ago

Hi @gpefanis,

thanks for bringing this up. We'll look into this.

Cheers, Peer