search

mainIine / foe-helfer-extension

FoE Helfer - Extension for chromium based browsers and Firefox ;-)
https://foe-helper.com
GNU Affero General Public License v3.0
122 stars 180 forks source link

stored buildings remain visible in city overview #2406

Open Beelzebob6666 opened 2 years ago

Beelzebob6666 commented 2 years ago

image

Gindi4711 commented 2 years ago

Yes you are right, but unfortunately this is not easy to fix.

What happens when you store a building: .) A request is sent with requestClass "UseItemOnBuildingPayload" and class "UseItemOnBuildingPayload". This contains itemId and mapEntityId .) The reply does not contain any valueable information

From the request alone we know the building, but not if it was a store building kit (could also be an upgrade kit etc.)

So to fix this we would need to listen to these requests and search Inventory for the ItemId and check if it was a "store building" kit.

The problem about that is that we currently do not track inventory changes. We currently only do that for FP packets. So the fix would fail if you did not have a store building kit when reloading the game.

Note: The lack of inventory tracking is also a problem for the Kits module, so I think it would be better to fix inventory first

oesi03 commented 2 years ago

Note: The lack of inventory tracking is also a problem for the Kits module, so I think it would be better to fix inventory first 👍gebt bitte Bescheid wenn ihr da schon was habt ansonsten bin ich da auch dran wenn ich Zeit habe😅 👍please let me know if you already have something, otherwise I'll be there too if I have time😅