mainIine / foe-helfer-extension

FoE Helfer - Extension for chromium based browsers and Firefox ;-)
https://foe-helper.com
GNU Affero General Public License v3.0
122 stars 180 forks source link

[Bug] - Abandoned Quest Counter #2541

Closed Arklur closed 1 year ago

Arklur commented 1 year ago

If you abandon 2 quests at the "same time", faster than the server can process the 1st abandoned quest, the counter decreases only by 1, not 2, see the GIF below.

FoeHelperRecurringQuestCounterBug

Explains why on specific days when I've put 20-30k FPs on my GBs in a "quick" session, I run out of the 2k limit when the counter was still at ~650-670.

Windows 10 64 Bit Chrome 107.0.5304.107 (64 bites) us1 (Arvahall) 2.12.1.0 - English

-Armchair developer ON- Checking again, my previous khm "idea" was wrong as hell, a simply loop here would fix the problem?

FoEproxy.addHandler('QuestService', 'getUpdates', (data, postData) => {
    if(postData[0]['requestClass'] === 'QuestService' && postData[0]['requestMethod'] === 'abortQuest'){
        Quests.UpdateCounter();
    }
});

-Armchair developer OFF-

Arklur commented 1 year ago

The 6ea60d81b0cdb64e2bbb70b23c0c3ff48b9f6899 and ba5a18791500fd88bc682469c56753f5fef8b5b5 commits (will) fix the issue.