search

mainIine / foe-helfer-extension

FoE Helfer - Extension for chromium based browsers and Firefox ;-)
https://foe-helper.com
GNU Affero General Public License v3.0
121 stars 181 forks source link

Filter Kits/Sets #2564

Closed ycram closed 1 year ago

ycram commented 1 year ago

Missed the possibility to search for kits/sets/items so I just tried to implement it.

Beelzebob6666 commented 1 year ago

Sorry for the late review

Looks good - Thanks for your contribution!

I will only add a minor CSS change to the top-bar and add the german translation

One thing missing is the translation capability for the placeholder, but I guess the users will figure that out.

Beelzebob6666 commented 1 year ago

Unfortunately I did not recognize that your request was for the master - as pull requests have to refer beta, I messed this one up.

I will update the beta with your changes manually.

ycram commented 1 year ago

Sorry for the inconvenience, didn't know it had to target beta instead. Didn't expect it to be accepted without further discussion/changes as I'm only starting to play with JS a bit. Glad it didn't seem so bad :D Thanks!

Beelzebob6666 commented 1 year ago

Looked good and worked - that is what counts :D

Did not look like a first time code to me - guess you bring some experience from another coding language.