search

mainIine / foe-helfer-extension

FoE Helfer - Extension for chromium based browsers and Firefox ;-)
https://foe-helper.com
GNU Affero General Public License v3.0
119 stars 181 forks source link

Attrition save to snapshot log, too #2728

Closed valimaties closed 5 months ago

valimaties commented 5 months ago

Righ now, the attrition is showing in the main window of GbG Overview. Snapshot Log window, however, shows only the negotiations, fights and total, attrition is missing. Could this be implemented?

outoftheline commented 5 months ago

the snapshot is incorrect if you do not track exactly at reset.

here is an example: let's say you log out 3 hours before reset and log back in 5hours after. someone with 0 attrition that day does 500 fights before reset and 500 more after it. they have 100-ish attrition when you log in again. if we add sttrition the data would make it look like they gained only 100 attrition from 1000 fights, which is incorrect.

we won't add numbers that will be incorrect for 95% of players most of the time. it will just lead to confusion.

outoftheline commented 5 months ago

if you do want to track attrition, you can use the export function at reset, the attrition is included there. image

valimaties commented 5 months ago

I see... unknowing fights and negotiations for each day is somehow hard to know how many fights and negotiations were done in current day round... We know attrition for each day, but we don't know the other values. However, I see the limitation but IMO is good to view it in snapshot than export it into a csv/Excel file... I know that first snapshot is inaccurate, but the rest of the day are good.

Arklur commented 5 months ago

We know attrition for each day

You do not. If you don't login for 3 days, you have no idea about others' attrition for those 3 days. Fights and negs are different, as the server do send that total amount of fights/negs, it's not calculated by FH. Even if you miss 3 days, the total for those attributes will be correct.

As outoftheline said, although that number could be correct if the player checks the attrition seconds before reset, for the majority of the users it would be incorrect. So, unless Inno decides to send the cumulated attrition for players too similarly how it's done with negs and battles, this won't be implemented, or at least very-very-very unlikely.

It's better to have 1 out of 100 users to miss this feature than 99 out of 100 complain about the number being off.

valimaties commented 5 months ago

Sad. Thanks.