mainio / decidim-module-term_customizer

Decidim module that allows customizing the localization terms in the system for specific contexts.
GNU Affero General Public License v3.0
16 stars 21 forks source link

Fix database not available (Zeitwerk and Docker error) #103

Open armandfardeau opened 1 year ago

armandfardeau commented 1 year ago

This modules use a database for initialization but in some cases (Zeitwerk checks or precompilation of assets on Docker) a database is not available.

This P.R. allows usage in theses cases.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (abbf0c6) 96.79% compared to head (5c2b648) 96.79%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #103 +/- ## ======================================== Coverage 96.79% 96.79% ======================================== Files 58 58 Lines 1153 1153 ======================================== Hits 1116 1116 Misses 37 37 ``` | [Files Changed](https://app.codecov.io/gh/mainio/decidim-module-term_customizer/pull/103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mainio) | Coverage Δ | | |---|---|---| | [lib/decidim/term\_customizer/i18n\_backend.rb](https://app.codecov.io/gh/mainio/decidim-module-term_customizer/pull/103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mainio#diff-bGliL2RlY2lkaW0vdGVybV9jdXN0b21pemVyL2kxOG5fYmFja2VuZC5yYg==) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Quentinchampenois commented 10 months ago

Hello @sinaeftekhar, Thank you for the review, I think I will continue this PR

If the change request only concerns typos in tests I can open a new PR to fix typos because I don't have write rights on the @armandfardeau's fork

Quentinchampenois commented 1 week ago

Hello, this PR won't be continued here but I can apply change request on a new one if needed

FYI, we already use this fix on our fork for containerized apps