mainio / decidim-module-term_customizer

Decidim module that allows customizing the localization terms in the system for specific contexts.
GNU Affero General Public License v3.0
16 stars 21 forks source link

Fix/import excel error with nil header cells #113

Open sinaeftekhar opened 10 months ago

sinaeftekhar commented 10 months ago

Sometimes the excel files might contain nil values which is not evident to the users eye, but messes with the app. This fix solves this problem. Fixes issue #91

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (abbf0c6) 96.79% compared to head (90e08d6) 96.71%. Report is 7 commits behind head on master.

Files Patch % Lines
lib/decidim/term_customizer/import/readers/xlsx.rb 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #113 +/- ## ========================================== - Coverage 96.79% 96.71% -0.08% ========================================== Files 58 58 Lines 1153 1157 +4 ========================================== + Hits 1116 1119 +3 - Misses 37 38 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.