mainio / decidim-module-term_customizer

Decidim module that allows customizing the localization terms in the system for specific contexts.

GNU Affero General Public License v3.0

15 stars 21 forks source link

Update DECIDIM_VERSION to be more flexible #26

Closed aitorlb closed 4 years ago

aitorlb commented 4 years ago

At CodiTramuntana we make heavy use of this gem (it's great!), as you can see here: https://github.com/mainio/decidim-module-term_customizer/network/dependents

It would be great if the DECIDIM_VERSION was less restrictive as we like to update our applications fairly soon; we are now upgrading to decidim 0.19.0 but we find that we need to keep a fork as the original repo does not allow us to upgrade.

codecov-io commented 4 years ago

Codecov Report

Merging #26 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files          59       59           
  Lines        1188     1188           
=======================================
  Hits         1157     1157           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c827f33...3a124f7. Read the comment docs.

ahukkanen commented 4 years ago

Hi @aitorlb !

Yes, I can totally understand this but currently Decidim is not guaranteed to maintain backwards compatibility with each version update. Until that changes, we want to stick with the version it is tested with and guaranteed to work with.

In case we would introduce the proposed change, there is a chance we would break many Decidim instances using this gem during updates which is not what we want to do.

We would, however, appreciate a PR that updates the Decidim dependencies to 0.19.x.