search

mainio / decidim-module-term_customizer

Decidim module that allows customizing the localization terms in the system for specific contexts.
GNU Affero General Public License v3.0
15 stars 21 forks source link

[FIX] Added NoMethodError to rescue in clear_cache #31

Closed victorol1 closed 4 years ago

victorol1 commented 4 years ago

Added NoMethodError in rescue in order to solve Memcached throwing NoMethodError in clear_cache.

Fixes issue: #30

ahukkanen commented 4 years ago

Thanks a lot @victorol1 !

Looks simple and clear.

Could you please add test cases for this case? Similar to the memcached store tests: https://github.com/mainio/decidim-module-term_customizer/blob/5d7dca16af4f4cb049f1f573f6c5eefd8b427fc0/spec/lib/decidim/term_customizer/loader_spec.rb#L114

victorol1 commented 4 years ago

Thanks a lot @victorol1 !

Looks simple and clear.

Could you please add test cases for this case? Similar to the memcached store tests:

https://github.com/mainio/decidim-module-term_customizer/blob/5d7dca16af4f4cb049f1f573f6c5eefd8b427fc0/spec/lib/decidim/term_customizer/loader_spec.rb#L114

@ahukkanen Added test, sorry for the delay!

victorol1 commented 4 years ago

@ahukkanen review when possible please