Add process groups - Githubissues

mainio / decidim-module-term_customizer

Decidim module that allows customizing the localization terms in the system for specific contexts.

GNU Affero General Public License v3.0

16 stars 21 forks source link

Add process groups #94

Open eliegaboriau opened 2 years ago

eliegaboriau commented 2 years ago

This PR allows admins to add constraints about process groups.

It could closes #75 and it is based on those specs

paulinebessoles commented 2 years ago

@ahukkanen I tested Elie's branch and it works for me in local 😁

paulinebessoles commented 1 year ago

Sorry for the late reply! I tested again and it works for me 😁 @eliegaboriau could you update your branch so it matches the main branch recent commits? @ahukkanen do you think you can review and merge this contribution in the next days?

eliegaboriau commented 1 year ago

It should be okay now !

eliegaboriau commented 1 year ago

Hello @ahukkanen, thanks for your review ! I've just changed a few things following your requests :

I've moved the manifests method in the module methods and remove all calls to the helper.
I've removed the participatory_process_group argument i was working with, and used the space instead. It seems to work well. Tell me if it seems okay !

paulinebessoles commented 1 year ago

@ahukkanen Is this solution right for you?