search

mainmatter / cargo-autoinherit

(Auto)DRY for your Rust dependencies
Apache License 2.0
130 stars 8 forks source link

Support for features seems to be missing #10

Closed AndreasOM closed 7 months ago

AndreasOM commented 7 months ago

I just ran this on one of our projects, and it totally wrecked it. It looks like features support is missing, or not working.

For Example: chrono = { version = "0.4.31", features = ["serde"] } got replaced with chrono = "0.4.31"

and

tokio = { version = "1.35.1", features = ["full"] }
tokio = "1.35.1"
LukeMathWalker commented 7 months ago

Can you link a minimum reproduction for us to test against? E.g. was the list of features you "lost" specified in workspace.dependencies or in a member's manifest?

AndreasOM commented 7 months ago

It was in the workspace itself, not in one of the members.

Sorry, but a bit busy right now, so can't create a repro, but can rerun now and then.

LukeMathWalker commented 7 months ago

That's enough to debug, I think I know where the issue is.

AndreasOM commented 7 months ago

Seems to work for our project now.