search

mainmatter / ember-asset-size-action

Comment with the diff for the asset sizes on Pull Request
MIT License
22 stars 15 forks source link

Support the ability to use PR Artifacts located at the dist location, relieving resources for (re)building #12

Closed NullVoxPopuli closed 1 year ago

NullVoxPopuli commented 4 years ago

Depends on: https://github.com/simplabs/ember-asset-size-action/pull/11

NullVoxPopuli commented 3 years ago

I'm catching up on context here, because it's been a while, and I want to track asset sizes over on: https://limber.glimdown.com

What's left exactly? I mean: https://github.com/simplabs/ember-asset-size-action/pull/8 needs to be rebased But here, you want to re-implement actions/download? How do we do that? 🤔

mansona commented 3 years ago

@NullVoxPopuli I'm going to comment on #8 as well but I think we need to split up these PRs to make them a bit easier to follow 🙃

If #8 is required then we should focus on that one first and then come back to this when it is done 👍

mansona commented 1 year ago

I'm closing this for now. Please see my last two comments in https://github.com/mainmatter/ember-asset-size-action/pull/8#issuecomment-1483925491 for an explanation 👍