mainmatter / ember-asset-size-action

Comment with the diff for the asset sizes on Pull Request
MIT License
22 stars 15 forks source link

feat: allow for bot to edit existing asset size comment #18

Closed Techn1x closed 3 years ago

Techn1x commented 3 years ago

closes https://github.com/simplabs/ember-asset-size-action/issues/9

Adds an optional config option update-comments to have the bot update existing comments rather than create new ones. Code adapted from a fork that implements this https://github.com/backspace/ember-asset-size-action/commit/040f42b218b77ad3bca9bb2cba479f73d742006f

From another repo I have that is using this PR Screenshot from 2021-01-28 09-27-39 ^ original comment v edited comment when a new commit is pushed Screenshot from 2021-01-28 10-00-51

timiyay commented 3 years ago

@mansona @NullVoxPopuli we've been using this PR for a few months now, and it has been working well.

What help can I provide to get this merged?

mansona commented 3 years ago

sorry I had to just check my logic for the update-comments code was working. Apparently inputs get converted to strings so we can' properly use booleans 🙃 🙈

Techn1x commented 3 years ago

Woo! Thanks for cleaning this up a bit and getting it across the line.

This GitHub action has helped us reduce bundle sizes significantly across our apps 👌

timiyay commented 3 years ago

Awesome, thanks @mansona and @Techn1x

@mansona What tag should we use to consume this new change? Do we target master or do you plan to tag the latest as v2 or something like that?

mansona commented 3 years ago

@timiyay I'm in the process of getting ready for a v2 release to add this stuff. I had a bit of a nightmare with ESM and Github actions but I have figure it all out now and were almost ready to go 👍

Once https://github.com/simplabs/ember-asset-size-action/pull/30 #29 and #28 are reviewed and merged I will "cut" a v2 release and update the readme to reflect that

mansona commented 3 years ago

That's all released now! thanks everyone for your contributions 🎉