search

mainmatter / ember-asset-size-action

Comment with the diff for the asset sizes on Pull Request
MIT License
22 stars 15 forks source link

Display total bundle sizes #24

Closed timiyay closed 1 year ago

timiyay commented 3 years ago

We'd like to see total bundle sizes reported from this Github Action, in addition to the size changes already reported.

This will help us manage total bundle size over time, like setting budgets with https://github.com/kaliber5/ember-cli-bundlesize.

As a stretch goal, we'd love to have an integration option for https://github.com/kaliber5/ember-cli-bundlesize, so the total bundle size display can be customised, based on configured size budgets.

I'm happy to implement this myself and contribute a PR. Firstly, I'm trying to gauge whether that PR would have any chance of being merged. We've been using a fork of this repo for 6 months, waiting for https://github.com/simplabs/ember-asset-size-action/pull/18 to be merged, but it seems this repo isn't maintained or accepting PRs in any practical sense?

timiyay commented 3 years ago

I'll get a PR together for this today.

Update: PR working and ready at https://github.com/simplabs/ember-asset-size-action/pull/27

vst commented 3 years ago

I think that this is quite useful, especially after ember-auto-import v2 started producing more chunks.

rahulk94 commented 3 years ago

This looks like quite a useful feature to pick up so +1 to getting this merged

rahulk94 commented 2 years ago

I've raised https://github.com/simplabs/ember-asset-size-action/pull/34 which shows a total size diff. This is slightly diff to https://github.com/simplabs/ember-asset-size-action/pull/27 but may be useful to some looking for total size reporting features.

mansona commented 1 year ago

This has been fixed in https://github.com/mainmatter/ember-asset-size-action/pull/64 which is really just a repurposing of https://github.com/mainmatter/ember-asset-size-action/pull/41 because I wasn't able to push to the branch that the PR was created from