search

mainmatter / ember-asset-size-action

Comment with the diff for the asset sizes on Pull Request
MIT License
22 stars 15 forks source link

Update dependencies #30

Closed mansona closed 3 years ago

mansona commented 3 years ago

This is a follow-on PR to https://github.com/simplabs/ember-asset-size-action/pull/26 and it turns out the method I was using didn't actually update all the dependencies all the way 🙃 usually this doesn't make a difference but since node_modules need to be baked in for GitHub actions this did cause a bit of a problem

I haven't been able to remove all security warnings on GitHub but the last one will be a problem for next week 😉

marhigh commented 3 years ago

Hi @mansona! Would you please use @simplabs/engineering for these type of reviews? We split it up on purpose to avoid me accidentally "design reviewing" something that needs to be "engineering reviewed".

mansona commented 3 years ago

ah right whoops! 🙈 I didn't even notice there was a difference, thanks for letting me know @marhigh 👍