search

mainmatter / ember-asset-size-action

Comment with the diff for the asset sizes on Pull Request
MIT License
22 stars 15 forks source link

How do I contribute? #31

Closed NullVoxPopuli closed 1 year ago

NullVoxPopuli commented 3 years ago

idk what's going on with npm, but no matter what, all of node_modules is changed when I run npm install, even on master branch

mansona commented 3 years ago

so this is a bit of an issue with github actions I'm afraid 😞 it's documented in their "how to work with github actions" but also very briefly in the auto-generated https://github.com/simplabs/ember-asset-size-action/blob/master/docs/contributors.md

essentially GitHub made the terrible decision to force you to commit all of your node_modules for people to use your action. It has been widely criticised and they said they might do something about it, but no word yet

mansona commented 1 year ago

This has been fixed in #43

Now we effectively bundle the code down to a single file (including all dependencies) and we verify that this dist file has been updated on a PR's CI so it doesn't go out of sync 👍