mainmatter / ember-asset-size-action

Comment with the diff for the asset sizes on Pull Request
MIT License
22 stars 15 forks source link

Refactor a smidge, so that future PRs can better build off the smaller methods #32

Closed NullVoxPopuli closed 1 year ago

NullVoxPopuli commented 3 years ago

... and we don't end up with a mega method.

This is required for #8 and is the main blocker to reviewing #8

Commits are atomic, so reviewing per commit may be benificial

mansona commented 1 year ago

I'm closing this for now. Please see my last two comments in https://github.com/mainmatter/ember-asset-size-action/pull/8#issuecomment-1483925491 for an explanation 👍