search

mainmatter / ember-asset-size-action

Comment with the diff for the asset sizes on Pull Request
MIT License
22 stars 15 forks source link

Update display of unchanged files #5

Closed mydea closed 1 year ago

mydea commented 4 years ago

Currently, it prints the files that have an unchanged filesize the same way, in a table. This makes the comment noisier than it needs to be, IMHO, so I wonder what you think about removing this from the comment.

Personally, I only really care about files that have been changed, and the list of files can become quite long (e.g. if using engines, every single unchanged engine file will be listed).

Thanks for the great work here!

mansona commented 4 years ago

I would be happy to add that as a config to say "don't show unchanged files" 🤔 but I think that for the default use case it is better to have an explicit comment to give confidence that XYZ.file hasn't changed by what I have done in a PR. Does that make sense?

mydea commented 4 years ago

Yeah, makes sense! I think having a configuration option for that would be awesome :+1:

mansona commented 1 year ago

I ended up wrapping all files in a <details> block in #48 since we now support changes in chunks and there can be a lot of chunks 🙈

I am going to close this issue since it pretty much solves the problem with noise (as long as nobody expands the details block 😂)

Let me know if you don't consider this fixed 👍