search

mainmatter / ember-asset-size-action

Comment with the diff for the asset sizes on Pull Request
MIT License
22 stars 15 forks source link

Add support for deleted files #65

Closed mansona closed 1 year ago

mansona commented 1 year ago

Right now the comment that is generated by this action splits the files into 3 different sections

This misses the last possible classification files that were deleted and you can see that in the code we have a TODO to cover this case: https://github.com/mainmatter/ember-asset-size-action/blob/master/lib/helpers.mjs#L46

Deleted files should be tracked in a new distinct section so that they are explicitly deleted and not just that they got smaller by 100% 👍

mansona commented 1 year ago

This is fixed since https://github.com/mainmatter/ember-asset-size-action/pull/41 was merged