search

mainmatter / ember-simple-auth

A library for implementing authentication/authorization in Ember.js applications.
https://ember-simple-auth.com
MIT License
1.92k stars 605 forks source link

ember-fetch@^6.0.0 #1705

Closed theseyi closed 5 years ago

theseyi commented 5 years ago

ember-fetch@^6.0.0 has been released, ember-simple-auth should upgrade to and/or support this version:

"dependencies": {
  "ember-fetch": "^2.1.0 || ^3.0.0 || ^4.0.0 || ^5.0.0",
}

should be:

"dependencies": {
  "ember-fetch": "^2.1.0 || ^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0",
}
marcoow commented 5 years ago

Can you submit a PR?

andreyfel commented 5 years ago

This blocks upgrading projects with mono-repo to ember-cli 3.5 because of the bug fixed in ember-fetch 6.1.1.

lougreenwood commented 5 years ago

I also had an issue when using latest ember-fetch with prember & ember-simple-auth:

https://github.com/ember-cli/ember-fetch/issues/166

andreyfel commented 5 years ago

Created pr #1713 to address that issue.

andreyfel commented 5 years ago

@mike-north is it possible to release a new version of ember-simple-auth with this change?