search

mainmatter / ember-simple-auth

A library for implementing authentication/authorization in Ember.js applications.
https://ember-simple-auth.com
MIT License
1.92k stars 604 forks source link

Build error while trying to run tests locally #2864

Open Gaurav0 opened 2 weeks ago

Gaurav0 commented 2 weeks ago

Versions:

ember-cli: 5.12.0 node: 20.18.0 pnpm: 9.12.3 os: darwin arm64 (MacOS Sequoia 15.1)

In package test-esa:

[gaurav.munjal@MacBookPro test-esa (gaurav/feat/support_partitioned_cookies)]$ ember test   
Environment: test
⠋ BuildingTorii is installed but not configured in config/environment.js!
cleaning up...
Cleanup error.
⠋ cleaning upCannot read properties of undefined (reading 'cleanup')

Stack Trace and Error Report: /var/folders/5n/x1_c935x0sq7lnqzfpsjkt080000gn/T/error.dump.873624881ff2ed0e4589d628770e0a6b.log
ENOENT: no such file or directory, stat '/Users/gaurav.munjal/dev/work/mainmatter/ember-simple-auth/packages/ember-simple-auth/node_modules/.bin/pnpm'

Stack Trace and Error Report: /var/folders/5n/x1_c935x0sq7lnqzfpsjkt080000gn/T/error.dump.9fa6036dd8b668dd27bb4d3ea3bda321.log
[gaurav.munjal@MacBookPro test-esa (gaurav/feat/support_partitioned_cookies)]$ node -v
v20.18.0
[gaurav.munjal@MacBookPro test-esa (gaurav/feat/support_partitioned_cookies)]$ npm -v
10.8.2
[gaurav.munjal@MacBookPro test-esa (gaurav/feat/support_partitioned_cookies)]$ pnpm -v
9.12.3
[gaurav.munjal@MacBookPro test-esa (gaurav/feat/support_partitioned_cookies)]$ ember -v
ember-cli: 5.12.0
node: 20.18.0
os: darwin arm64

Note that I get the same error running: pnpm run --filter test-esa test pnpm run --filter test-esa test:one ember-default

Gaurav0 commented 2 weeks ago

It looks like adding

hoist=true
hoist-workspace-packages=true

to .npmrc and rerunning pnpm i solves this problem. Would you like me to open a PR with this change?